Skip to content

Conversation

@pkhry
Copy link

@pkhry pkhry commented Oct 22, 2025

Description

Notes

sudden DuplicateContract errors when using with latest master

Copy link

@alexggh alexggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me let's get this stuff merged.

Could you also mark here #265 all the cheatcodes that should now work.

None
}
// Remove duplicate acceses in storage_recorder
fn revive_remove_duplicate_account_access(&self, _state: &mut crate::Cheatcodes) {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why is this needed ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate placeholder records are added in Inspector::call_with_executor/Inspector::create_common this ideally needs to be refactored and moved to strategies, but i'd rather wait and see how zk-foundry does it

@pkhry pkhry merged commit 90400aa into master Oct 26, 2025
69 of 91 checks passed
@pkhry pkhry deleted the pkhry/tracing branch October 26, 2025 21:09
iulianbarbu pushed a commit that referenced this pull request Oct 27, 2025
* add tracing support to resolc mode
* closes #328 
* closes #329
iulianbarbu added a commit that referenced this pull request Oct 27, 2025
iulianbarbu added a commit that referenced this pull request Oct 28, 2025
* anvil-polkadot: implement anvil_setCoinbase

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: added AURA based FindAuthor impl

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: add eth_coinbase and tests

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: polish code

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: apply fmt

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot(tests): test based on Multicall contract

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot(tests): adjust thresholds for timestamp tests on revert

Signed-off-by: Iulian Barbu <[email protected]>

* Update crates/anvil-polkadot/src/substrate_node/service/consensus.rs

* anvil-polkadot: address feedback part 1

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: address feedback part 2

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: address feedback part 3

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: address feedback part 4

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot(tests): removed unnecessary sol call conversions

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot(tests): remove other redundant SollCall conversions

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: use Error::RuntimeApi

Signed-off-by: Iulian Barbu <[email protected]>

* Update crates/anvil-polkadot/src/substrate_node/service/consensus.rs

* update to polkadot-sdk master (#352)

* Tracing support (#350)

* add tracing support to resolc mode
* closes #328 
* closes #329

* Revert "Tracing support (#350)"

This reverts commit 8129cfe.

* Revert "update to polkadot-sdk master (#352)"

This reverts commit af2eda8.

* anvil-polkadot(tests): fix test

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: fix rustfmt

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: use pallet-aura FindAuthor todo comment

Signed-off-by: Iulian Barbu <[email protected]>

* anvil-polkadot: address G feedback

Signed-off-by: Iulian Barbu <[email protected]>

---------

Signed-off-by: Iulian Barbu <[email protected]>
Co-authored-by: Alin Dima <[email protected]>
Co-authored-by: Pavlo Khrystenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Forge Test][Tracing] Implement tracing support in pvm mode.

4 participants