-
Notifications
You must be signed in to change notification settings - Fork 6
Tracing support #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing support #350
Conversation
alexggh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me let's get this stuff merged.
Could you also mark here #265 all the cheatcodes that should now work.
| None | ||
| } | ||
| // Remove duplicate acceses in storage_recorder | ||
| fn revive_remove_duplicate_account_access(&self, _state: &mut crate::Cheatcodes) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain why is this needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate placeholder records are added in Inspector::call_with_executor/Inspector::create_common this ideally needs to be refactored and moved to strategies, but i'd rather wait and see how zk-foundry does it
This reverts commit 8129cfe.
* anvil-polkadot: implement anvil_setCoinbase Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: added AURA based FindAuthor impl Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: add eth_coinbase and tests Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: polish code Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: apply fmt Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot(tests): test based on Multicall contract Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot(tests): adjust thresholds for timestamp tests on revert Signed-off-by: Iulian Barbu <[email protected]> * Update crates/anvil-polkadot/src/substrate_node/service/consensus.rs * anvil-polkadot: address feedback part 1 Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: address feedback part 2 Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: address feedback part 3 Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: address feedback part 4 Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot(tests): removed unnecessary sol call conversions Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot(tests): remove other redundant SollCall conversions Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: use Error::RuntimeApi Signed-off-by: Iulian Barbu <[email protected]> * Update crates/anvil-polkadot/src/substrate_node/service/consensus.rs * update to polkadot-sdk master (#352) * Tracing support (#350) * add tracing support to resolc mode * closes #328 * closes #329 * Revert "Tracing support (#350)" This reverts commit 8129cfe. * Revert "update to polkadot-sdk master (#352)" This reverts commit af2eda8. * anvil-polkadot(tests): fix test Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: fix rustfmt Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: use pallet-aura FindAuthor todo comment Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: address G feedback Signed-off-by: Iulian Barbu <[email protected]> --------- Signed-off-by: Iulian Barbu <[email protected]> Co-authored-by: Alin Dima <[email protected]> Co-authored-by: Pavlo Khrystenko <[email protected]>
Description
pvmmode. #327, [Forge test][Tracing] Implement base tracers #328expect_emit,expect_revert,recordLogsandAccountAccessesNotes
suddenDuplicateContracterrors when using with latest master